Example of hoisting devtools dependency #1303
Conversation
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| import 'dart:io'; | |||
|
|
|||
| import 'package:devtools_server/devtools_server.dart'; | |||
| typedef DevtoolsLauncher = Future<DevTools> Function(String hostname); | |||
There was a problem hiding this comment.
Won't this still require a dependency on DevTools given the type?
There was a problem hiding this comment.
I believe this is just the DevTools wrapper you wrote below
There was a problem hiding this comment.
Ah my mistake. We'll want to model this as a breaking change so we need a pubspec and changelog update. But otherwise LGTM.
There was a problem hiding this comment.
Will do, thanks!
| @@ -15,7 +15,7 @@ dependencies: | |||
| pedantic: ^1.5.0 | |||
| pub_semver: ^2.0.0 | |||
| sse: ^3.8.1 | |||
| web_socket_channel: ^1.0.0 | |||
| web_socket_channel: ^2.0.0 | |||
There was a problem hiding this comment.
this wasn't version solving locally
| @@ -1,6 +1,6 @@ | |||
| name: webdev | |||
| # Every time this changes you need to run `pub run build_runner build`. | |||
| version: 2.7.2 | |||
| version: 2.7.3 | |||
There was a problem hiding this comment.
I believe this is a non breaking change for webdev, but I'm not sure if this is a minor or patch version bump
| @@ -1,6 +1,6 @@ | |||
| name: webdev | |||
| # Every time this changes you need to run `pub run build_runner build`. | |||
| version: 2.7.2 | |||
| version: 2.7.3 | |||
dwds/CHANGELOG.md
Outdated
|
|
||
| - Support `vm_service` version `6.2.0`. | ||
| - Fix missing sdk libraries in `getObject()` calls. | ||
| - Fix incorrect `rootLib` returned by `ChromeProxyService`. | ||
| - Fix not working breakpoints in library part files. | ||
| - Fix data race in calculating locations for a module. | ||
|
|
||
| **Breaking changes:** | ||
| - `Dwds.start` no longer supports automatically injecting a devtools server. If `serveDevtools` is |
There was a problem hiding this comment.
Should we just combine this with devtoolsLauncher? If it returns null then we know serveDevtools is false. Seems a little redundant. Thoughts?
|
oops, took out the wrong field |
|
Current failures might be flakes? |
Likely. I've found Chrome to be pretty flaky in Github Actions. Re-running to confirm. |
|
It passed! |
From the dependency issue post mortem, @bkonyi asked about the source of this dep. I wanted to take a look and found that it seems fairly easy to hoist into webdev. @grouma